Skip to content

[sparkle] chore: remove DataTableLoadingSkeleton - #32276

Open
aubin-tchoi wants to merge 2 commits into
mainfrom
kill-data-source-skeleton
Open

[sparkle] chore: remove DataTableLoadingSkeleton#32276
aubin-tchoi wants to merge 2 commits into
mainfrom
kill-data-source-skeleton

Conversation

@aubin-tchoi

@aubin-tchoi aubin-tchoi commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description

Table skeletons should match the content of each cell. DataTableLoadingSkeleton encourages generic placeholders but cannot mimic details such as avatars, badges, or multiple text lines.

Remove the component, its export, and its stories. Replace its five usages with custom LoadingBlock compositions based on each table's actual cells, column widths, row heights, and responsive layout.

Tests

  • LoadingBlock and scrollable table stories pass locally. The table story reports existing accessibility warnings; the application tables have no Storybook coverage.

Risk

  • Low. Removes a Sparkle export; all repository callers are migrated.

Deploy Plan

  • Publish Sparkle and deploy front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant